Fix this-binding in getTA and getUser - #320
Open
sadegh wants to merge 1 commit into
Open
Conversation
getTA and getUser reach sibling functions through this, which is only the module when called as a method (TradingView.searchMarketV3(...)). With a destructured import the receiver is lost, so in this sloppy-mode CommonJS module this becomes globalThis and it throws 'this.getTA is not a function'. tests/search.test.ts imports that way, so the TA tests fail on main. Resolve through module.exports, which doesn't depend on the call site. Same fix applied to getUser's redirect recursion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTA and getUser reach sibling functions through
this, which only resolves when the function is called as a method:With a destructured import the receiver is lost.
miscRequests.jsis sloppy-mode CommonJS, sothisfalls back toglobalThisand the lookup throws:tests/search.test.tsimports exactly that way, so both "gets TA for ..." tests fail on current main. They pass with this change.Resolving through
module.exportsdoesn't depend on how the caller got the function. Applied the same fix togetUser's redirect recursion, which would throw the same way on any redirect.